Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(css): Update syntax for sizing properties #813

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

skyclouds2001
Copy link
Contributor

Description

sizing properties include height max-height max-width min-height min-width width

merge <length> | <percentage> to <length-percentage [0,∞]> per specification
update fit-content(<length-percentage>) to fit-content(<length-percentage [0,∞]>) per specification
add missing <calc-size()> function syntax, which is supported in chromium M129
add missing <anchor-size()> function syntax, which is supported in chromium M125
add non-standard -webkit-fill-available value, its standard value is stretch, which currently is not supported per BCD

Motivation

Additional details

https://drafts.csswg.org/css-sizing/#propdef-width
https://drafts.csswg.org/css-sizing/#propdef-height
https://drafts.csswg.org/css-sizing/#propdef-min-width
https://drafts.csswg.org/css-sizing/#propdef-min-height
https://drafts.csswg.org/css-sizing/#propdef-max-width
https://drafts.csswg.org/css-sizing/#propdef-max-height

https://drafts.csswg.org/css-sizing-4/#valdef-width-stretch
https://drafts.csswg.org/css-sizing/#funcdef-width-fit-content
https://drafts.csswg.org/css-anchor-position/#anchor-size-fn

Related issues and pull requests

@skyclouds2001 skyclouds2001 marked this pull request as ready for review December 2, 2024 19:24
@skyclouds2001 skyclouds2001 requested a review from a team as a code owner December 2, 2024 19:24
@skyclouds2001 skyclouds2001 requested review from pepelsbey and removed request for a team December 2, 2024 19:24
@skyclouds2001 skyclouds2001 changed the title Update syntax for sizing properties feat(css): Update syntax for sizing properties Dec 2, 2024
Copy link
Member

@pepelsbey pepelsbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you :)

@pepelsbey pepelsbey merged commit cd06f28 into mdn:main Dec 5, 2024
3 checks passed
@skyclouds2001 skyclouds2001 deleted the sizing-properties branch December 5, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants